linux-kernel - Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160518172637.GB6879@kroah.com>
Date:	Wed, 18 May 2016 10:26:37 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
Cc:	David Kershner <david.kershner@...sys.com>, corbet@....net,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	erik.arfvidson@...sys.com, timothy.sell@...sys.com,
	hofrat@...dl.org, dzickus@...hat.com, alexander.curtin@...sys.com,
	janani.rvchndrn@...il.com, sudipm.mukherjee@...il.com,
	prarit@...hat.com, david.binder@...sys.com, nhorman@...hat.com,
	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, driverdev-devel@...uxdriverproject.org,
	sparmaintainer@...sys.com
Subject: Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized
 devices to arch/x86

On Wed, May 18, 2016 at 12:03:58PM -0400, Jes Sorensen wrote:
> Greg KH <gregkh@...uxfoundation.org> writes:
> > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote:
> >> > Ok, but still no need to put it under arch/ anything, it should go in
> >> > drivers/ like all other drivers and busses are, no matter what the arch
> >> > it happens to run on is.
> >> 
> >> I don't think thats obvious. arch/x86/kvm is an example of this, Sparc
> >> and PPC also have their stuff under arch/.
> >
> > For some things, yes, but let's not make the same mistakes as others :)
> >
> > Look at drivers/hv/ for an example of a very x86-only bus and driver
> > subsystem living in drivers/  Please don't burry driver stuff in arch/
> > the ARM developers are trying to fix their mistakes of the past and move
> > all of their cruft out of arch/ for that reason.
> 
> Works for me.
> 
> So should they put it in drivers/visorbus or drivers/bus/visorbus?

drivers/visorbus please.  drivers/bus/ is an "odd" thing :(

> What about drivers/virt? Would you suggest hv and xen gets moved in
> there?

Ah, yeah, that would be great, never noticed it before, despite being
there since 2011...

thanks,

greg k-h