linux-kernel - Re: [PATCH 1/5] headers_check: don't warn about c++ guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo51FkfzzhFjYKyyHfxb-DyZeheQP2oZG-tWf1-EiBakp2w@mail.gmail.com>
Date:	Wed, 18 May 2016 21:20:29 +0100
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	David Airlie <airlied@...ux.ie>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"moderated list:ARM/S5P EXYNOS AR..." 
	<linux-samsung-soc@...r.kernel.org>,
	ML nouveau <nouveau@...ts.freedesktop.org>,
	Seung-Woo Kim <sw0312.kim@...sung.com>,
	Russell King <rmk+kernel@...linux.org.uk>,
	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Alex Deucher <alexander.deucher@....com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	linux-mediatek@...ts.infradead.org,
	Ben Skeggs <bskeggs@...hat.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Christian König <christian.koenig@....com>,
	LAKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/5] headers_check: don't warn about c++ guards

On 18 May 2016 at 17:07, Arnd Bergmann <arnd@...db.de> wrote:
> A recent addition to the DRM tree for 4.7 added 'extern "C"' guards
> for c++ to all the DRM headers, and that now causes warnings
> in 'make headers_check':
>
> usr/include/drm/amdgpu_drm.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:63: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:699: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_fourcc.h:30: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_mode.h:33: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_sarea.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/exynos_drm.h:21: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/i810_drm.h:7: userspace cannot reference function or variable defined in the kernel
>
> This changes the headers_check.pl script to not warn about this.
> I'm listing the merge commit as introducing the problem, because
> there are several patches in this branch that each do this for
> one file.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 7c10ddf87472 ("Merge branch 'drm-uapi-extern-c-fixes' of https://github.com/evelikov/linux into drm-next")
Reviewed-by: Emil Velikov <emil.l.velikov@...il.com>

Thanks Arnd !

As Dave mentioned - the best solution would be to have the hunks
generated on the fly. Sadly Perl and me don't go hand in hand so if
you're interested I'll be really grateful.

-Emil