linux-kernel - Re: [PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160518232300.GA4243@rob-hp-laptop>
Date:	Wed, 18 May 2016 18:23:00 -0500
From:	Rob Herring <robh@...nel.org>
To:	Robin van der Gracht <robin@...tonic.nl>
Cc:	linux-kernel@...r.kernel.org, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
	Thierry Reding <treding@...dia.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Matt Ranostay <mranostay@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S . Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kalle Valo <kvalo@...eaurora.org>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Jiri Slaby <jslaby@...e.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller

On Wed, May 18, 2016 at 02:23:18PM +0200, Robin van der Gracht wrote:
> Added a driver for the Holtek HT16K33 LED controller with keyscan.
> 
> Signed-off-by: Robin van der Gracht <robin@...tonic.nl>
> ---
> Changes in v6:
>     - Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10'
> 
>  .../devicetree/bindings/display/ht16k33.txt        |  42 ++
>  drivers/auxdisplay/Kconfig                         |   9 +
>  drivers/auxdisplay/Makefile                        |   1 +
>  drivers/auxdisplay/ht16k33.c                       | 563 +++++++++++++++++++++
>  4 files changed, 615 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
>  create mode 100644 drivers/auxdisplay/ht16k33.c
> 
> diff --git a/Documentation/devicetree/bindings/display/ht16k33.txt b/Documentation/devicetree/bindings/display/ht16k33.txt
> new file mode 100644
> index 0000000..5c11320
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ht16k33.txt
> @@ -0,0 +1,42 @@
> +Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan
> +-------------------------------------------------------------------------------
> +
> +Required properties:
> +- compatible:		"holtek,ht16k33"
> +- reg:			I2C slave address of the chip.
> +- interrupt-parent:	A phandle pointing to the interrupt controller
> +			serving the interrupt for this chip.
> +- interrupts:		Interrupt specification for the key pressed interrupt.
> +- refresh-rate-hz:	Display update interval in HZ.
> +- debounce-delay-ms:	Debouncing interval time in microseconds.

The units and description still don't match.

I acked the last one. Please add acks when sending new versions (unless 
of course you don't fix any trivial things noted).

Rob