linux-kernel - [PATCH 3.12 25/76] bus: imx-weim: Take the 'status' property value into account

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b4a6367c6632234a8241d0c1f39405dffb90769e.1463648873.git.jslaby@suse.cz>
Date:	Thu, 19 May 2016 11:07:47 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	stable@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@....com>,
	Olof Johansson <olof@...om.net>, Jiri Slaby <jslaby@...e.cz>
Subject: [PATCH 3.12 25/76] bus: imx-weim: Take the 'status' property value into account

From: Fabio Estevam <fabio.estevam@....com>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit 33b96d2c9579213cf3f36d7b29841b1e464750c4 upstream.

Currently we have an incorrect behaviour when multiple devices
are present under the weim node. For example:

&weim {
	...
	status = "okay";

	sram@0,0 {
		...
        	status = "okay";
	};

	mram@0,0 {
		...
        	status = "disabled";
    	};
};

In this case only the 'sram' device should be probed and not 'mram'.

However what happens currently is that the status variable is ignored,
causing the 'sram' device to be disabled and 'mram' to be enabled.

Change the weim_parse_dt() function to use
for_each_available_child_of_node()so that the devices marked with
'status = disabled' are not probed.

Suggested-by: Wolfgang Netbal <wolfgang.netbal@...matek.at>
Signed-off-by: Fabio Estevam <fabio.estevam@....com>
Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de>
Acked-by: Shawn Guo <shawnguo@...nel.org>
Signed-off-by: Olof Johansson <olof@...om.net>
Signed-off-by: Jiri Slaby <jslaby@...e.cz>
---
 drivers/bus/imx-weim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 3ef58c8dbf11..78737f4fd894 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -92,7 +92,7 @@ static int __init weim_parse_dt(struct platform_device *pdev,
 	struct device_node *child;
 	int ret;
 
-	for_each_child_of_node(pdev->dev.of_node, child) {
+	for_each_available_child_of_node(pdev->dev.of_node, child) {
 		if (!child->name)
 			continue;
 
-- 
2.8.2