linux-kernel - Re: [PATCH v3 12/14] staging: comedi: daqboard2000: rename reference DACs register macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573D9064.2050009@mev.co.uk>
Date:	Thu, 19 May 2016 11:07:32 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	devel@...verdev.osuosl.org
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 12/14] staging: comedi: daqboard2000: rename reference
 DACs register macros

On 19/05/16 10:58, Ian Abbott wrote:
> Rename the macros that define values for the reference DACs register to
> avoid CamelCase, and to make it clearer which register they are
> associated with.  Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
> `0x0080` that triggers setting one of the references.
>
> Signed-off-by: Ian Abbott <abbotti@....co.uk>
> Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> ---
> v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
> v3: Corrected typo in commit:  0x80 --> 0x0080.
> ---
>   drivers/staging/comedi/drivers/daqboard2000.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)

Dammit!  I missed the other, glaring typo in the commit. 
`DAQBOARD2000_REF_DACS_SET` should be `DB2K_REQ_DACS_SET`.  I'll post a 
v4 of this patch.  Sorry for the bother.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-