linux-kernel - Re: [PATCH] amdgpu/uvd: use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160519114921.GA14314@kp>
Date:	Thu, 19 May 2016 17:19:21 +0530
From:	Muhammad Falak R Wani <falakreyaz@...il.com>
To:	Christian König <christian.koenig@....com>
Cc:	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>,
	Chunming Zhou <David1.Zhou@....com>,
	Jammy Zhou <Jammy.Zhou@....com>, Leo Liu <leo.liu@....com>,
	Sonny Jiang <sonny.jiang@....com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] amdgpu/uvd: use kmemdup

On Thu, May 19, 2016 at 01:18:10PM +0200, Christian König wrote:
> Am 19.05.2016 um 13:11 schrieb Muhammad Falak R Wani:
> >Use kmemdup when some other buffer is immediately copied into allocated
> >region. It replaces call to allocation followed by memcpy, by a single
> >call to kmemdup.
> >
> >Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> 
> NAK, actually using memcpy() is wrong in the first place.
> 
> The UVD BO is in VRAM so the pointer is pointing to IO memory here,
> so this should be memcpy_fromio() instead of memcpy().
> 
> Christian.
> 
Should I send V2 with the required changes, and I had a query, 
If memcpy was wrong, did it still work or it just got un-noticed ?