linux-kernel - [PATCH] mm: compact: fix zoneindex in compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463659121-84124-1-git-send-email-puck.chen@hisilicon.com>
Date:	Thu, 19 May 2016 19:58:41 +0800
From:	Chen Feng <puck.chen@...ilicon.com>
To:	<puck.chen@...ilicon.com>, <mhocko@...e.com>,
	<kirill.shutemov@...ux.intel.com>, <vbabka@...e.cz>,
	<hannes@...xchg.org>, <tj@...nel.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>
CC:	<suzhuangluan@...ilicon.com>, <dan.zhao@...ilicon.com>,
	<qijiwen@...ilicon.com>, <xuyiping@...ilicon.com>,
	<oliver.fu@...ilicon.com>, <puck.chen@...mail.com>
Subject: [PATCH] mm: compact: fix zoneindex in compact

While testing the kcompactd in my platform 3G MEM only DMA ZONE.
I found the kcompactd never wakeup. It seems the zoneindex
has already minus 1 before. So the traverse here should be <=.

Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
---
 mm/compaction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 8fa2540..e5122d9 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1742,7 +1742,7 @@ static bool kcompactd_node_suitable(pg_data_t *pgdat)
 	struct zone *zone;
 	enum zone_type classzone_idx = pgdat->kcompactd_classzone_idx;
 
-	for (zoneid = 0; zoneid < classzone_idx; zoneid++) {
+	for (zoneid = 0; zoneid <= classzone_idx; zoneid++) {
 		zone = &pgdat->node_zones[zoneid];
 
 		if (!populated_zone(zone))
-- 
1.9.1