linux-kernel - [PATCH 1/2] Input: atmel captouch depends on i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2016 15:52:24 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>,
	Daniel Hung-yu Wu <hywu@...gle.com>
Subject: [PATCH 1/2] Input: atmel captouch depends on i2c

The newly added Atmal captouch driver fails to build when CONFIG_I2C
is disabled:

drivers/input/misc/atmel_captouch.c: In function 'atmel_read':
drivers/input/misc/atmel_captouch.c:115:8: error: implicit declaration of function 'i2c_transfer' [-Werror=implicit-function-declaration]

This adds an explicit Kconfig dependency to prevent the broken
configuration.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: b06d43f7a3db ("Input: add Atmel Captouch Button driver")
---
 drivers/input/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 9c3dfe79d4d4..27d6da0e354a 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -85,6 +85,7 @@ config INPUT_ARIZONA_HAPTICS
 config INPUT_ATMEL_CAPTOUCH
 	tristate "Atmel Capacitive Touch Button Driver"
 	depends on OF || COMPILE_TEST
+	depends on I2C
 	help
 	  Say Y here if an Atmel Capacitive Touch Button device which
 	  implements "captouch" protocol is connected to I2C bus. Typically
-- 
2.7.0