linux-kernel - RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AT5PR84MB0036169C5D8EB84F52038C2CCA4A0@AT5PR84MB0036.NAMPRD84.PROD.OUTLOOK.COM>
Date:	Thu, 19 May 2016 13:49:16 +0000
From:	"N, Soumya P" <soumya.p.n@....com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock
 variant of tasklist_lock is not held from interrupt context it is not
 necessary to disable interrupts.

Hi Steve,

Thanks for the explanation.
I will take care of your comments and send v2 of the same patch.

Thanks,
Soumya.
-----Original Message-----
From: Steven Rostedt [mailto:rostedt@...dmis.org] 
Sent: Thursday, May 19, 2016 6:41 PM
To: N, Soumya P <soumya.p.n@....com>
Cc: mingo@...hat.com; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.

On Thu, 19 May 2016 08:53:17 +0000
"N, Soumya P" <soumya.p.n@....com> wrote:

> Hi Steve,
> 
> Could you please explain what this error means?
> Is it related to length of subject?
> I have run checkpatch.pl on patch and didn't show any error.
> 
> Thanks,
> Soumya.
> 
> -----Original Message-----
> From: Steven Rostedt [mailto:rostedt@...dmis.org]
> Sent: Thursday, May 19, 2016 1:25 AM
> To: N, Soumya P <soumya.p.n@....com>
> Cc: mingo@...hat.com; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts.
> 
> 
> -ERUNONSUBJECT

A subject (and this includes normal net etiquette as well) should be a short description of what the email (or patch) is about, preferably under 80 characters. What you supplied is an abstract.

it should have been something as simple as:

 ftrace: Don't disable interrupts when taking read_lock() for graph tracer

And don't rely on checkpatch.pl. Read Documentation/SubmittingPatches in the kernel proper.

-- Steve