linux-kernel - RE: [PATCH] [SCSI] aacraid: use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2016 18:25:06 +0000
From:	Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>,
	Hannes Reinecke <hare@...e.com>
CC:	Adaptec OEM Raid Solutions <aacraid@...ptec.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [SCSI] aacraid: use kmemdup


> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
> owner@...r.kernel.org] On Behalf Of Muhammad Falak R Wani
> Sent: Thursday, May 19, 2016 7:09 AM
> To: Hannes Reinecke
> Cc: Adaptec OEM Raid Solutions; James E.J. Bottomley; Martin K. Petersen;
> linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] [SCSI] aacraid: use kmemdup
> 
> EXTERNAL EMAIL
> 
> 
> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---
>  drivers/scsi/aacraid/commctrl.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
> index 4b3bb52..b381b37 100644
> --- a/drivers/scsi/aacraid/commctrl.c
> +++ b/drivers/scsi/aacraid/commctrl.c
> @@ -635,15 +635,14 @@ static int aac_send_raw_srb(struct aac_dev* dev,
> void __user * arg)
>                         }
>                 } else {
>                         struct user_sgmap* usg;
> -                       usg = kmalloc(actual_fibsize - sizeof(struct aac_srb)
> -                         + sizeof(struct sgmap), GFP_KERNEL);
> +                       usg = kmemdup(upsg,
> +                                     actual_fibsize - sizeof(struct aac_srb)
> +                                     + sizeof(struct sgmap), GFP_KERNEL);
>                         if (!usg) {
>                                 dprintk((KERN_DEBUG"aacraid: Allocation error in Raw SRB
> command\n"));
>                                 rcode = -ENOMEM;
>                                 goto cleanup;
>                         }
> -                       memcpy (usg, upsg, actual_fibsize - sizeof(struct aac_srb)
> -                         + sizeof(struct sgmap));
>                         actual_fibsize = actual_fibsize64;
> 
>                         for (i = 0; i < usg->count; i++) {

Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>