linux-kernel - Re: [PATCH 1/1] net: hns: avoid null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160519.112607.1614392639969487509.davem@davemloft.net>
Date:	Thu, 19 May 2016 11:26:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xypron.glpk@....de
Cc:	Yisen.Zhuang@...wei.com, yankejian@...wei.com,
	lisheng011@...wei.com, liguozhu@...wei.com, andrew@...n.ch,
	salil.mehta@...wei.com, xieqianqian@...wei.com,
	huangdaode@...ilicon.com, chenny.xu@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] net: hns: avoid null pointer dereference

From: Heinrich Schuchardt <xypron.glpk@....de>
Date: Tue, 17 May 2016 22:01:15 +0200

> In the statement
>   assert(priv || priv->ae_handle);
> the right side of || is only evaluated if priv is null.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>

I agree with others that this assert() is pretty useless and should
simply be removed.