linux-kernel - Re: [PATCH] scsi: ultrastor.c depends on ISA_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160519191400.GA16573@sophia>
Date:	Thu, 19 May 2016 15:14:00 -0400
From:	William Breathitt Gray <vilhelm.gray@...il.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] scsi: ultrastor.c depends on ISA_DMA_API

On Thu, May 19, 2016 at 02:53:35PM -0400, William Breathitt Gray wrote:
>Although request_dma and free_dma are conditionally dependent on
>CONFIG_ISA_DMA_API inside the arch/x86/include/asm/dma.h file, they are
>defined inside the kernel/dma.c file which depends on
>CONFIG_GENERIC_ISA_DMA in order to build on X86. Therefore,
>GENERIC_ISA_DMA should be in the depends line for SCSI_ULTRASTOR instead
>of ISA_DMA_API.
>
>William Breathitt Gray

My apologies, I was too quick to send and didn't realize
CONFIG_GENERIC_ISA_DMA is "def_bool y" in X86. In that case, ISA_DMA_API
should suffice; thus the line becomes:

    depends X86 && SCSI && ISA_DMA_API

William Breathitt Gray