linux-kernel - Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160519222711.GF552@pd.tnic>
Date:	Fri, 20 May 2016 00:27:11 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	nick <xerofoify@...il.com>
Cc:	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] edac:Fix kernel panic regression in
 edac_mc_reset_delay_period

On Thu, May 19, 2016 at 06:10:37PM -0400, nick wrote:
> Here is the issue though it does not happen on v4.4 but on newer
> kernels. I bisected it and it does work if the commit I stated is
> reverted, and working at that commit the only line changed in any
> function is in my patch. Here we can add a check like your asking:

This is not what I hinted at. I hinted at checking ->op_state in
edac_mc_reset_delay_period() before doing edac_mod_work().

Here's another hint: ->op_state gets set to OP_RUNNING_POLL only when
->edac_check is not NULL.

Better?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.