linux-kernel - Re: get_maintainer.pl and MAINTAINERS file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463697173.14098.46.camel@perches.com>
Date:	Thu, 19 May 2016 15:32:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jiri Slaby <jslaby@...e.cz>, Kalle Valo <kvalo@...eaurora.org>,
	Robin van der Gracht <robin@...tonic.nl>
Cc:	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Kumar Gala <galak@...eaurora.org>,
	"David S . Miller" <davem@...emloft.net>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
	Matt Ranostay <mranostay@...il.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Jonathan Cameron <jic23@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Thierry Reding <treding@...dia.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: get_maintainer.pl and MAINTAINERS file

On Thu, 2016-05-19 at 21:53 +0200, Jiri Slaby wrote:
> Cc: joe
> 
> On 05/19/2016, 02:57 PM, Kalle Valo wrote:
> > 
> > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
> > 
> > Robin van der Gracht <robin@...tonic.nl> writes:
> > 
> > > 
> > > > 
> > > > And 4th, what is with the insane number of people on cc:?  Use
> > > > get_maintainer.pl correctly please, and don't just hit everyone you
> > > > can possibly think of with a cc: for no good reason.
> > > I did use the get_maintainer script. I solely passed the patch set as
> > > command line argument.
> > I think get_maintainer script should ignore MAINTAINERS file altogether.

Maybe, maybe not.
The list of MAINTAINERS names returned by get_maintainer.pl is:

Andrew Morton <akpm@...ux-foundation.org> (commit_signer:39/504=8%)
"David S. Miller" <davem@...emloft.net> (commit_signer:38/504=8%)
Greg Kroah-Hartman <gregkh@...uxfoundation.org> (commit_signer:36/504=7%)
Kalle Valo <kvalo@...eaurora.org> (commit_signer:28/504=6%)
Mauro Carvalho Chehab <mchehab@....samsung.com> (added_lines:109/2073=5%,removed_lines:108/779=14%)
Guenter Roeck <linux@...ck-us.net> (removed_lines:48/779=6%)
Jiri Slaby <jslaby@...e.com> (removed_lines:46/779=6%)

> > After I did drivers/net/wireless reorganisation, and had to make
> > numerous changes to MAINTAINERS in the process, I have been CCed to all
> > sorts of patchsets to which I have nothing to do with (this one
> > included). I suspect get_maintainer.pl is to blame here.

Doubtful but possible.
I have no idea how many files were modified by whatever
patch was checked, but more files, more maintainers.

Unmaintained files have even more "not quite maintainers",
but get_maintainer.pl lists the names of people that recently
modified those specific files.

> Last time I even tried to fix this up, but failed due to time
> limitations as the code is a bit complex.
> 
> Joe, you seem to be the one who touched the script many times recently.
> May we ask you to fix this up?

I'm not touching stuff right now.  Maybe next month.