linux-kernel - Re: [PATCH] mpssd: fix buffer overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tnm1tvb29z59h.fsf@phwtpriv05.ph.intel.com>
Date:	Fri, 20 May 2016 01:07:38 -0400
From:	Ashutosh Dixit <ashutosh.dixit@...el.com>
To:	Mike Danese <mikedanese@...gle.com>
Cc:	"Dutt\, Sudeep" <sudeep.dutt@...el.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Chandramouli\, Dasaratharaman" 
	<dasaratharaman.chandramouli@...el.com>,
	Mahesh Khanwalkar <maheshkhanwalkar@...il.com>,
	"open list\:DOCUMENTATION" <linux-doc@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mpssd: fix buffer overflow warning

On Fri, May 20 2016 at 12:54:51 AM, Mike Danese <mikedanese@...gle.com> wrote:
> The compilation emits a warning in function ‘snprintf’,
>     inlined from ‘set_cmdline’ at
>     ../Documentation/mic/mpssd/mpssd.c:1541:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
>     warning: call to __builtin___snprintf_chk will always overflow
>     destination buffer
>
> This was introduced in commit f4a66c204482 ("misc: mic: Update MIC host
> daemon with COSM changes") and is fixed by reverting the changes to the
> size argument of these snprintf statements.

Thanks for the patch, the fix is fine.