linux-kernel - Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160520061824.GA7086@linux-uzut.site>
Date:	Thu, 19 May 2016 23:18:24 -0700
From:	Davidlohr Bueso <dave@...olabs.net>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jason Low <jason.low2@....com>, Ingo Molnar <mingo@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>,
	Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Terry Rudd <terry.rudd@....com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnd Bergmann <arnd@...db.de>,
	Christoph Lameter <cl@...ux.com>,
	Waiman Long <Waiman.Long@....com>,
	Tim Chen <tim.c.chen@...ux.intel.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Jason Low <jason.low2@...com>
Subject: Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to
 atomic_long_t

On Tue, 17 May 2016, Peter Zijlstra wrote:

>Subject: locking,rwsem: Remove rwsem_atomic_add() and rwsem_atomic_update()
>From: Jason Low <jason.low2@....com>
>Date: Mon, 16 May 2016 17:38:02 -0700
>
>The rwsem-xadd count has been converted to an atomic variable and the
>rwsem code now directly uses atomic_long_add() and
>atomic_long_add_return(), so we can remove the arch implementations of
>rwsem_atomic_add() and rwsem_atomic_update().
>
>Cc: Waiman Long <Waiman.Long@....com>
>Cc: Heiko Carstens <heiko.carstens@...ibm.com>
>Cc: Jason Low <jason.low2@...com>
>Cc: Richard Henderson <rth@...ddle.net>
>Cc: Ingo Molnar <mingo@...hat.com>
>Cc: Fenghua Yu <fenghua.yu@...el.com>
>Cc: Andrew Morton <akpm@...ux-foundation.org>
>Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
>Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>Cc: Tim Chen <tim.c.chen@...ux.intel.com>
>Cc: Christoph Lameter <cl@...ux.com>
>Cc: Thomas Gleixner <tglx@...utronix.de>
>Cc: Arnd Bergmann <arnd@...db.de>
>Cc: Terry Rudd <terry.rudd@....com>
>Cc: Peter Hurley <peter@...leysoftware.com>
>Cc: Davidlohr Bueso <dave@...olabs.net>

Acked-by: Davidlohr Bueso <dave@...olabs.net>

>Cc: Ivan Kokshaysky <ink@...assic.park.msu.ru>
>Cc: Tony Luck <tony.luck@...el.com>
>Cc: Matt Turner <mattst88@...il.com>
>Signed-off-by: Jason Low <jason.low2@....com>
>Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>---
> arch/alpha/include/asm/rwsem.h |   42 -----------------------------------------
> arch/ia64/include/asm/rwsem.h  |    7 ------
> arch/s390/include/asm/rwsem.h  |   37 ------------------------------------
> arch/x86/include/asm/rwsem.h   |   18 -----------------
> include/asm-generic/rwsem.h    |   16 ---------------
> 5 files changed, 120 deletions(-)

Nice. This, along with Michal's work getting rid of a lot of superfluous
implementations, have gotten rid of plenty of rwsem code in arch/*

Thanks,
Davidlohr