linux-kernel - Re: [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573EABD8.7040206@nvidia.com>
Date:	Fri, 20 May 2016 11:46:56 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Keerthy <a0393675@...com>, Nishanth Menon <nm@...com>,
	Mark Brown <broonie@...nel.org>
CC:	Tony Lindgren <tony@...mide.com>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, Liam Girdwood <lgirdwood@...il.com>,
	Keerthy <j-keerthy@...com>, Stephen Warren <swarren@...dia.com>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes


On Friday 20 May 2016 10:01 AM, Keerthy wrote:
> + Lee Jones
>
> On Saturday 07 May 2016 12:31 AM, Nishanth Menon wrote:
>> On 05/06/2016 12:14 PM, Mark Brown wrote:
>>> On Fri, May 06, 2016 at 12:44:23PM +0530, Laxman Dewangan wrote:
>>>
>>>> When you are here, can you implement the dt parsing with the new 
>>>> method from
>>>> regulator framework.
>>>> Regulator FW calls callback to parse customized DT property, just 
>>>> need to
>>>> pass the node and pointer when registering.
>>>
>>>> This will helps lots in cleanups and readability.
>>>
>>> Yes, please.
>>>
>> yeah, the driver has started showing it's age, it will be good to do a
>> refactor.
>
> Laxman,
>
> I got the dt parsing with new method from regulator framework part, But
> by new method do you also want to remove the dt compatible of 
> regulators and let only the mfd compatible stay?
>
> replace of_platform_populate with mfd_add_devices so that linux 
> handles the drivers split up and not the device tree?
>

The DT binding of child devices of the palmas are like that each sub 
node has compatible.
So I dont think we can change this to avoid regression.

However, if we make the child devices independent of the parent devices 
then it will be very useful to use across different PMIC if they have 
same IP.
Currently, child devices are very much tightly coupled with parent 
devices for the register access and global structure member accces.

This is exactly what we did for the max77686 RTC driver which is used by 
max77686, max77802 and max77620.

There is two mfd core driver, max77686 and max77620 and uses same RTC 
driver rtc-max77686.c