linux-kernel - Re: [PATCH 0/4] x86/fpu/state: Fix XSAVES issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160520071200.GC4003@gmail.com>
Date:	Fri, 20 May 2016 09:12:00 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Yu-cheng Yu <yu-cheng.yu@...el.com>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Andy Lutomirski <luto@...nel.org>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>,
	"Ravi V. Shankar" <ravi.v.shankar@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH 0/4] x86/fpu/state: Fix XSAVES issues - Part 1


* Yu-cheng Yu <yu-cheng.yu@...el.com> wrote:

> This is Part 1 of previous 13 XSAVES patches. Break it down to
> smaller series. There are no code changes; only minor fixes in
> the titles.
> 
> Fenghua Yu (3):
>   x86/fpu/xstate: Define and use fpu_user_xstate_size
>   x86/fpu/xstate: Rename xstate_size to fpu_kernel_xstate_size to
>     distinguish from fpu_user_xstate_size
>   x86/fpu/xstate: Keep init_fpstate.xsave.header.xfeatures as zero for
>     init optimization
> 
> Yu-cheng Yu (1):
>   x86/fpu/xstate: Copy xstate registers directly to signal frame when
>     compacted format is in use
> 
>  arch/x86/include/asm/fpu/xstate.h |  2 +-
>  arch/x86/include/asm/processor.h  |  3 +-
>  arch/x86/kernel/fpu/core.c        |  7 +--
>  arch/x86/kernel/fpu/init.c        | 21 +++++----
>  arch/x86/kernel/fpu/signal.c      | 32 ++++++++++----
>  arch/x86/kernel/fpu/xstate.c      | 92 +++++++++++++++++++++++----------------
>  6 files changed, 98 insertions(+), 59 deletions(-)

Hm, the series does not apply cleanly:

 patching file arch/x86/include/asm/fpu/xstate.h
 patching file arch/x86/include/asm/processor.h
 patching file arch/x86/kernel/fpu/init.c
 patching file arch/x86/kernel/fpu/signal.c
 patching file arch/x86/kernel/fpu/xstate.c
 Hunk #4 FAILED at 552.
 1 out of 6 hunks FAILED -- rejects in file arch/x86/kernel/fpu/xstate.c

which suggests that this series isn't against a recent x86 tree, right?

Thanks,

	Ingo