linux-kernel - Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160520075348.GI23234@mail.corp.redhat.com>
Date:	Fri, 20 May 2016 09:53:48 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Bastien Nocera <hadess@...ess.net>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lejun Zhu <lejun.zhu@...ux.intel.com>,
	Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the
 Surface 3

On May 17 2016 or thereabouts, Bastien Nocera wrote:
> On Fri, 2016-05-13 at 18:05 +0200, Benjamin Tissoires wrote:
> > Hi,
> > 
> > This is the v2 of the series with 3 extra patches to add support of
> > the buttons
> > found on the Surface 3.
> > 
> > Cheers,
> > Benjamin
> > 
> > 
> > Benjamin Tissoires (6):
> >   Input - soc_button_array: use gpio_is_valid()
> >   Input - soc_button_array: bail out earlier if gpiod_count is null
> >   Input - soc_button_array: make sure one GPIO is not assigned twice
> >   Input - soc_button_array: allow to specify active_low
> >   Input - soc_button_array: export part of the internals
> >   Input - surface3_button_array: Introduce button support for the
> >     Surface 3
> 
> Works on my Surface 3, the volume buttons, and the Windows button work
> as expected. Note that the power button does not send out any events on
> my machine, but that might be due to firmware differences.
> 
> My BIOS is listed as version 1.51116.78 released 03/09/2015.
> 
> As there's no errors generated, it would be fine to look at it as a bug
> fix later on (or for me to updated my system).
> 
> Tested-by: Bastien Nocera <hadess@...ess.net>

Bastien told me in a different thread that the power button is not
working only after a reboot from Windows. After a cold start, it works
fine. There might be something that needs to be set at the I2C level,
but I think while we don't know much about the I2C protocol there, it
should be safe to still get this upstream.

Cheers,
Benjamin