linux-kernel - Re: [PATCH] irqchip: nps: add 64BIT dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573EC932.5060106@synopsys.com>
Date:	Fri, 20 May 2016 13:52:10 +0530
From:	Vineet Gupta <vgupta@...opsys.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Arnd Bergmann <arnd@...db.de>
Cc:	Jason Cooper <jason@...edaemon.net>, Noam Camus <noamc@...hip.com>,
	arcml <linux-snps-arc@...ts.infradead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Marc Zyngier <marc.zyngier@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip: nps: add 64BIT dependency

On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> The newly added nps irqchip driver causes build warnings on ARM64.
>>
>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>
>> As the driver is only used on ARC, we don't need to see it without
>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/irqchip/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 83775f148158..37289cf6b449 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>
>>  config EZNPS_GIC
>>         bool "NPS400 Global Interrupt Manager (GIM)"
>> +       depends on ARC || (COMPILE_TEST && !64BIT)
>>         select IRQ_DOMAIN
>>         help
>>           Support the EZchip NPS400 global interrupt controller
> 
> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
> the slight simpler (whitespace-damaged):

I'm afraid you are late to party - this has been sent Linus' way earlier today !
But it does look prettier so we can do this after rc1

> 
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -255,7 +255,8 @@ config PARTITION_PERCPU
>         bool
> 
>  config EZNPS_GIC
> -       bool "NPS400 Global Interrupt Manager (GIM)"
> +       bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
> +       depends on !64BIT
>         select IRQ_DOMAIN
>         help
>           Support the EZchip NPS400 global interrupt controller
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>