linux-kernel - Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period due to missing mode operation check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160520084244.GA501@pd.tnic>
Date:	Fri, 20 May 2016 10:42:44 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] edac:Fix kernel panic regression in
 edac_mc_reset_delay_period due to missing mode operation check

On Thu, May 19, 2016 at 06:45:58PM -0400, Nicholas Krause wrote:
> This fixes a kernel panic regression in the function,
> edac_mc_reset_delay_period as show by this kernel panic
> trace:

...

>  drivers/edac/edac_mc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index 6aa256b0..c3ee3ad 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -565,7 +565,8 @@ void edac_mc_reset_delay_period(unsigned long value)
>  	list_for_each(item, &mc_devices) {
>  		mci = list_entry(item, struct mem_ctl_info, link);
>  
> -		edac_mod_work(&mci->work, value);
> +		if (mci->op_state == OP_RUNNING_POLL)
> +			edac_mod_work(&mci->work, value);
>  	}
>  	mutex_unlock(&mem_ctls_mutex);
>  }
> -- 

Looks good to me. I'll apply it after the merge window is over.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.