linux-kernel - Re: [PATCH] security: tomoyo: simplify the gc kthread creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201605202059.EFG78110.OOQFJFHLFMtSVO@I-love.SAKURA.ne.jp>
Date:	Fri, 20 May 2016 20:59:17 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	mikedanese@...gle.com, james.l.morris@...cle.com
Cc:	takedakn@...data.co.jp, serge@...lyn.com,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security: tomoyo: simplify the gc kthread creation

Mike Danese wrote:
> The code is doing the equivalent of the kthread_run macro.
> 
> Signed-off-by: Mike Danese <mikedanese@...gle.com>

Acked-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

> ---
>  security/tomoyo/gc.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/security/tomoyo/gc.c b/security/tomoyo/gc.c
> index 986a6a7..540bc29 100644
> --- a/security/tomoyo/gc.c
> +++ b/security/tomoyo/gc.c
> @@ -645,11 +645,6 @@ void tomoyo_notify_gc(struct tomoyo_io_buffer *head, const bool is_register)
>  		}
>  	}
>  	spin_unlock(&tomoyo_io_buffer_list_lock);
> -	if (is_write) {
> -		struct task_struct *task = kthread_create(tomoyo_gc_thread,
> -							  NULL,
> -							  "GC for TOMOYO");
> -		if (!IS_ERR(task))
> -			wake_up_process(task);
> -	}
> +	if (is_write)
> +		kthread_run(tomoyo_gc_thread, NULL, "GC for TOMOYO");
>  }
> -- 
> 2.5.0
> 
>