linux-kernel - Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 21:04:57 +0800
From:	Shawn Lin <shawn.lin@...k-chips.com>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	shawn.lin@...k-chips.com, Heiko Stuebner <heiko@...ech.de>,
	Mark Brown <broonie@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	devicetree@...r.kernel.org, Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
	linux-rockchip@...ts.infradead.org,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] ARM: dts: rockchip: fixes the spi compatible for
 rk3036

在 2016/5/20 20:57, Caesar Wang 写道:
>
> 于 2016年05月20日 20:35, Shawn Lin 写道:
>> 在 2016/5/20 7:56, Caesar Wang 写道:
>>> That's seem the incorrect string to match the spi driver.
>>>
>>
>> Will it break the backward compatibility for some dtb if not
>> falling back to "rockchip,rockchip-spi" ?
>
> The rk3036 shouldn't work if you read the driver/spi/spi-rockchip.c.
> since the "rockchip,rockchip-spi" is *not* exist in linux kernel.
>

okay, so that means we take "rockchip,rockchip-spi" from local branch
by mistake?

> ..
>  static const struct of_device_id rockchip_spi_dt_match[] = {
>     { .compatible = "rockchip,rk3066-spi", },
>     { .compatible = "rockchip,rk3188-spi", },
>     { .compatible = "rockchip,rk3288-spi", },
>     { .compatible = "rockchip,rk3399-spi", },
>     { },
> }
> ..
>
>
> -Caesar
>
>>
>>> Fixes commit f629fcfab2cd
>>> ("ARM: dts: rockchip: support the spi for rk3036")
>>>
>>> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
>>> Cc: Heiko Stuebner <heiko@...ech.de>
>>> Cc: linux-rockchip@...ts.infradead.org
>>>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>>  arch/arm/boot/dts/rk3036.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/rk3036.dtsi
>>> b/arch/arm/boot/dts/rk3036.dtsi
>>> index d0f4bb7..a30700a 100644
>>> --- a/arch/arm/boot/dts/rk3036.dtsi
>>> +++ b/arch/arm/boot/dts/rk3036.dtsi
>>> @@ -431,7 +431,7 @@
>>>      };
>>>
>>>      spi: spi@...74000 {
>>> -        compatible = "rockchip,rockchip-spi";
>>> +        compatible = "rockchip,rk3036-spi";
>>>          reg = <0x20074000 0x1000>;
>>>          interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>>>          clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>;
>>>
>>
>>
>>
>>
>


-- 
Best Regards
Shawn Lin