linux-kernel - [PATCH 3/3] drm/imx: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1463751294-24769-4-git-send-email-LW@KARO-electronics.de>
Date:	Fri, 20 May 2016 15:34:54 +0200
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	David Airlie <airlied@...ux.ie>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	Sascha Hauer <kernel@...gutronix.de>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Lothar Waßmann <LW@...O-electronics.de>
Subject: [PATCH 3/3] drm/imx: remove dead code

The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.

Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>
---
 drivers/gpu/drm/imx/parallel-display.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 440f34d..e37d0e6 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -39,7 +39,6 @@ struct imx_parallel_display {
 	int edid_len;
 	u32 bus_format;
 	u32 bus_flags;
-	int mode_valid;
 	struct drm_display_mode mode;
 	struct drm_panel *panel;
 };
@@ -74,17 +73,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 	}
 
-	if (imxpd->mode_valid) {
-		struct drm_display_mode *mode = drm_mode_create(connector->dev);
-
-		if (!mode)
-			return -EINVAL;
-		drm_mode_copy(mode, &imxpd->mode);
-		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
-		drm_mode_probed_add(connector, mode);
-		num_modes++;
-	}
-
 	if (np) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 		struct videomode vm;
-- 
2.1.4