linux-kernel - Re: [PATCH 1/2] drm/amd/powerplay: fix bugs of checking if dpm is running on Tonga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573F1731.7020800@vodafone.de>
Date:	Fri, 20 May 2016 15:54:57 +0200
From:	Christian König <deathsimple@...afone.de>
To:	dri-devel@...ts.freedesktop.org
Cc:	daniel.vetter@...ll.ch, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drm/amd/powerplay: fix bugs of checking if dpm is
 running on Tonga

Please ignore this one, I was on the wrong branch while sending mails.

Christian.

Am 20.05.2016 um 15:53 schrieb Christian König:
> From: Eric Huang <JinHuiEric.Huang@....com>
>
> Fixes OD failures on Tonga.
>
> Reviewed-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Eric Huang <JinHuiEric.Huang@....com>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>
> ---
>   drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> index cb28335..7c3f82b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> @@ -5331,7 +5331,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table &
>   		(DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {
>   		PP_ASSERT_WITH_CODE(
> -			true == tonga_is_dpm_running(hwmgr),
> +			0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to freeze SCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5344,7 +5344,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   	if ((0 == data->mclk_dpm_key_disabled) &&
>   		(data->need_update_smu7_dpm_table &
>   		 DPMTABLE_OD_UPDATE_MCLK)) {
> -		PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),
> +		PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to freeze MCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5647,7 +5647,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table &
>   		(DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {
>   
> -		PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),
> +		PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to Unfreeze SCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5661,7 +5661,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_MCLK)) {
>   
>   		PP_ASSERT_WITH_CODE(
> -				true == tonga_is_dpm_running(hwmgr),
> +				0 == tonga_is_dpm_running(hwmgr),
>   				"Trying to Unfreeze MCLK DPM when DPM is disabled",
>   				);
>   		PP_ASSERT_WITH_CODE(