linux-kernel - Re: [PATCH] fbcon: warn on invalid cursor blink intervals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1605200937330.18587@laptop>
Date:	Fri, 20 May 2016 11:27:17 -0500 (CDT)
From:	Scot Doyle <lkml14@...tdoyle.com>
To:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:	Jeremy Kerr <jk@...abs.org>, Ming Lei <ming.lei@...onical.com>,
	David Daney <david.daney@...ium.com>,
	Dann Frazier <dann.frazier@...onical.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Pavel Machek <pavel@....cz>, Jonathan Liu <net147@...il.com>,
	Alistair Popple <alistair@...ple.id.au>,
	Jean-Philippe Brucker <jean-philippe.brucker@....com>,
	"Chintakuntla, Radha" <Radha.Chintakuntla@...iumnetworks.com>,
	Jiri Slaby <jslaby@...e.com>, David Airlie <airlied@...ux.ie>,
	David Daney <ddaney.cavm@...il.com>,
	Scot Doyle <lkml14@...tdoyle.com>,
	dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals

On Fri, 20 May 2016, Jeremy Kerr wrote:
> Hi Ming,
> 
> >Then looks there are two fix patches acked & tested:
> >
> > - the patch in this thread
> > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor
> >blink timer."
> > https://lkml.org/lkml/2016/5/17/455
> >
> >So which one will be pushed to linus?
> 
> Not that it's my call, but we may want both; the first as a safety
> measure to prevent an invalid cur_blink_jiffies ever being set, and the
> second one to actually fix the initialisation of vc_cur_blink_ms (and
> address the warning introduced by the first).

Tomi / Greg,

I'd suggest
- applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and stable[4.2]
- applying "fbcon: warn on invalid cursor blink intervals" to 4.7
- ignoring "fbcon: use default if cursor blink interval is not valid"

Note: the patches don't depend on each other


> I guess we could just go with the latter for stable...
>
> Cheers,
> 
> Jeremy