linux-kernel - Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKzfze_7C-WWy0NUtgAEj5XYZ-qUmMWxEOVV8-F9haU=CW_tLQ@mail.gmail.com>
Date:	Fri, 20 May 2016 10:34:54 -0700
From:	Matt Ranostay <mranostay@...il.com>
To:	Alison Schofield <amsfield22@...il.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: humidity: hdc100x: add HDC1000 and HDC1008 product names

On Fri, May 20, 2016 at 10:05 AM, Alison Schofield <amsfield22@...il.com> wrote:
> hdc100x supports Texas Instruments HDC1000 and HDC1008 relative
> humidity and temperature sensors. Add these product names to
> Kconfig and to the drivers device id structure to enable finding
> the product by name and using it to add a device.
>
> Signed-off-by: Alison Schofield <amsfield22@...il.com>
> Cc: Daniel Baluta <daniel.baluta@...il.com>
> ---
>  drivers/iio/humidity/Kconfig   | 8 ++++----
>  drivers/iio/humidity/hdc100x.c | 2 ++
>  2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index 738a86d..f155386 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -26,11 +26,11 @@ config HDC100X
>         tristate "TI HDC100x relative humidity and temperature sensor"
>         depends on I2C
>         help
> -        Say yes here to build support for the TI HDC100x series of
> -        relative humidity and temperature sensors.
> +         Say yes here to build support for the Texas Instruments
> +         HDC1000 and HDC1008 relative humidity and temperature sensors.
>
> -        To compile this driver as a module, choose M here: the module
> -        will be called hdc100x.
> +         To compile this driver as a module, choose M here: the module
> +         will be called hdc100x.
>
>  config HTU21
>         tristate "Measurement Specialties HTU21 humidity & temperature sensor"
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index fa47676..0deb874 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -302,6 +302,8 @@ static int hdc100x_probe(struct i2c_client *client,
>
>  static const struct i2c_device_id hdc100x_id[] = {
>         { "hdc100x", 0 },
> +       { "hdc1000", 0 },
> +       { "hdc1008", 0 },

Personally I think adding more device ids that don't add any per chip
configuration is just adding clutter.
There is a reason I used "hdc100x" when I wrote the driver :)


>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);
> --
> 2.1.4
>