lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 May 2016 10:44:34 -0700 From: Matt Ranostay <mranostay@...il.com> To: Alison Schofield <amsfield22@...il.com> Cc: Jonathan Cameron <jic23@...nel.org>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] iio: humidity: hdc100x: correct humidity integration time mask Reviewed-by: Matt Ranostay <mranostay@...il.com> On Fri, May 20, 2016 at 10:06 AM, Alison Schofield <amsfield22@...il.com> wrote: > Apply the correct mask to enable all available humidity integration > times. Currently, the driver defaults to 6500 and all is okay with that. > However, if 3850 is selected we get a stuck bit and can't change back > to 6500 or select 2500. (Verified with HDC1008) > > Signed-off-by: Alison Schofield <amsfield22@...il.com> > Cc: Daniel Baluta <daniel.baluta@...il.com> > --- > drivers/iio/humidity/hdc100x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c > index fa47676..59aa1cb 100644 > --- a/drivers/iio/humidity/hdc100x.c > +++ b/drivers/iio/humidity/hdc100x.c > @@ -55,7 +55,7 @@ static const struct { > }, > { /* IIO_HUMIDITYRELATIVE channel */ > .shift = 8, > - .mask = 2, > + .mask = 3, Yikes that is embarrassing on my part! I guess our validation was only in the high resolution mode... good catch! > }, > }; > > -- > 2.1.4 >
Powered by blists - more mailing lists