linux-kernel - Re: [PATCH v4 0/6] Add alignment check for DAX mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1463766042.32042.34.camel@hpe.com>
Date:	Fri, 20 May 2016 17:49:51 +0000
From:	"Kani, Toshimitsu" <toshi.kani@....com>
To:	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"jack@...e.cz" <jack@...e.cz>,
	"david@...morbit.com" <david@...morbit.com>,
	"sandeen@...deen.net" <sandeen@...deen.net>,
	"vishal.l.verma@...el.com" <vishal.l.verma@...el.com>
CC:	"Parrish, Micah (HP Servers Linux R&D)" <micah.parrish@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>,
	"adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
	"axboe@...com" <axboe@...com>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
	"tytso@....edu" <tytso@....edu>,
	"boaz@...xistor.com" <boaz@...xistor.com>
Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount

On Fri, 2016-05-20 at 17:34 +0000, Verma, Vishal L wrote:
> On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> > > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > > > 
> > > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > >
> > > Sorry for being late, but -
> > > 
> > > Shouldn't this and all subsequent patch commits refer to
> > > PAGE_SIZE, rather than "4kB?"
> >
> > Right, the patch commits should refer to PAGE_SIZE to match with the
> > code changes.  I am afraid it may be a bit too late to update,
> > though...
> > 
> > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
> > 
> > Thanks,
> > -Toshi
>
> Hi Toshi,
> 
> Is it just commit message changes? If so I'm not sure it is worthwhile
> to rebase everything for that - i.e. my dax error handling series and
> Ross' dax-locking branch would both have to be rebased..
> 
> If there are and fixes for code, we can do them as an add-on patch
> though.

Hi Vishal,

Yes, it is just commit messages, and it's OK not to make this change.

Thanks,
-Toshi