linux-kernel - Re: [RFC v2 4/7] asm/sections: add a generic push_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160520195320.GO11948@wotan.suse.de>
Date:	Fri, 20 May 2016 21:53:20 +0200
From:	"Luis R. Rodriguez" <mcgrof@...nel.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	"Luis R. Rodriguez" <mcgrof@...nel.org>, schwidefsky@...ibm.com,
	linux-s390@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	bp@...en8.de, x86@...nel.org, linux-kernel@...r.kernel.org,
	luto@...capital.net, boris.ostrovsky@...cle.com,
	rusty@...tcorp.com.au, david.vrabel@...rix.com,
	konrad.wilk@...cle.com, mcb30@...e.org, jgross@...e.com,
	ming.lei@...onical.com, gregkh@...uxfoundation.org, arnd@...db.de,
	linux-arch@...r.kernel.org, linux@....linux.org.uk,
	benh@...nel.crashing.org, jbaron@...mai.com, ananth@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	masami.hiramatsu.pt@...achi.com, andriy.shevchenko@...ux.intel.com,
	dwmw2@...radead.org, xen-devel@...ts.xensource.com,
	torvalds@...ux-foundation.org
Subject: Re: [RFC v2 4/7] asm/sections: add a generic push_section_tbl()

On Fri, Feb 26, 2016 at 03:56:04PM +0100, Heiko Carstens wrote:
> On Sun, Feb 21, 2016 at 06:55:05PM -0800, H. Peter Anvin wrote:
> > On 02/19/16 13:06, Luis R. Rodriguez wrote:
> > >>
> > >> I think the \n\t is unnecessary.
> > > 
> > > Super! I wonder if we we can just use this on s390 as well without it pooping?
> > > I ask as this would set a precedent.
> > > 
> > 
> > Ask Heike, but I think just ; or \n ought be be fine.  I do not know of
> > *any* case where \t at the end of a string would ever be necessary, and
> > it would *always* be possible to replace it with a space in a pinch.
> 
> \n should be fine on s390.

Great, thanks, I'll move forward with just \n in v3.

  Luis