| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1463786186-1065-1-git-send-email-Waiman.Long@hpe.com> Date: Fri, 20 May 2016 19:16:26 -0400 From: Waiman Long <Waiman.Long@....com> To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com> Cc: linux-kernel@...r.kernel.org, Davidlohr Bueso <dave@...olabs.net>, Jason Low <jason.low2@...com>, Dave Chinner <david@...morbit.com>, Peter Hurley <peter@...leysoftware.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Scott J Norton <scott.norton@....com>, Douglas Hatch <doug.hatch@....com>, Waiman Long <Waiman.Long@....com> Subject: [PATCH resend v4 3/5] locking/rwsem: Don't wake up one's own task As rwsem_down_read_failed() will queue itself and potentially call __rwsem_do_wake(sem, RWSEM_WAKE_ANY), it is possible that a reader will try to wake up its own task. This patch adds a check to make sure that this won't happen. Signed-off-by: Waiman Long <Waiman.Long@....com> Reviewed-by: Peter Hurley <peter@...leysoftware.com> --- kernel/locking/rwsem-xadd.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c index c278f5a..007814f 100644 --- a/kernel/locking/rwsem-xadd.c +++ b/kernel/locking/rwsem-xadd.c @@ -202,7 +202,8 @@ __rwsem_do_wake(struct rw_semaphore *sem, enum rwsem_wake_type wake_type) */ smp_mb(); waiter->task = NULL; - wake_up_process(tsk); + if (likely(tsk != current)) + wake_up_process(tsk); put_task_struct(tsk); } while (--loop); -- 1.7.1
Powered by blists - more mailing lists