linux-kernel - Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160520040836.GA573@swordfish>
Date:	Fri, 20 May 2016 13:08:36 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Dan Streetman <ddstreet@...e.org>
Cc:	Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>,
	Ganesh Mahendran <opensource.ganesh@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Seth Jennings <sjenning@...hat.com>,
	Yu Zhao <yuzhao@...gle.com>, Linux-MM <linux-mm@...ck.org>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dan Streetman <dan.streetman@...onical.com>
Subject: Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

On (05/19/16 11:18), Dan Streetman wrote:
[..]
>  	zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
>  	if (!zs_stat_root)
> -		return -ENOMEM;
> -
> -	return 0;
> +		pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
>  }
>  
>  static void __exit zs_stat_exit(void)
> @@ -573,17 +575,19 @@ static const struct file_operations zs_stat_size_ops = {
>  	.release        = single_release,
>  };
>  
> -static int zs_pool_stat_create(struct zs_pool *pool, const char *name)
> +static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
>  {
>  	struct dentry *entry;
>  
> -	if (!zs_stat_root)
> -		return -ENODEV;
> +	if (!zs_stat_root) {
> +		pr_warn("no root stat dir, not creating <%s> stat dir\n", name);
> +		return;
> +	}

just a small nit, there are basically two warn messages now for
`!zs_stat_root':

	debugfs 'zsmalloc' stat dir creation failed
	no root stat dir, not creating <%s> stat dir

may be we need only one of them; but no strong opinions.

	-ss