lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 May 2016 20:18:52 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Matt Ranostay <mranostay@...il.com>, sathyanarayanan.kuppuswamy@...ux.intel.com Cc: Alison Schofield <amsfield22@...il.com>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check functionality test On 19/05/16 21:19, Matt Ranostay wrote: > Reviewed-by: Matt Ranostay <matt.ranostay@...el.com> Applied to the togreg branch of iio.git. Thanks, Jonathan > > On Thu, May 19, 2016 at 11:37 AM, sathyanarayanan kuppuswamy > <sathyanarayanan.kuppuswamy@...ux.intel.com> wrote: >> Looks Good. >> >> Reviewed-by:Kuppuswamy Sathyanarayanan >> <sathyanarayanan.kuppuswamy@...ux.intel.com> >> >> >> On 05/15/2016 11:37 AM, Alison Schofield wrote: >>> >>> This driver does not call i2c_smbus_read|write_byte_data(), >>> so remove the corresponding functionality test. It uses regmap >>> to handle byte transfers transparently. >>> >>> Signed-off-by: Alison Schofield <amsfield22@...il.com> >>> --- >>> Found & fixed by inspection based on same defect recently fixed >>> in light/tpl0102 driver. >>> >>> >>> drivers/iio/light/jsa1212.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c >>> index 99a6281..e8a8931 100644 >>> --- a/drivers/iio/light/jsa1212.c >>> +++ b/drivers/iio/light/jsa1212.c >>> @@ -325,9 +325,6 @@ static int jsa1212_probe(struct i2c_client *client, >>> struct regmap *regmap; >>> int ret; >>> - if (!i2c_check_functionality(client->adapter, >>> I2C_FUNC_SMBUS_BYTE_DATA)) >>> - return -EOPNOTSUPP; >>> - >>> indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); >>> if (!indio_dev) >>> return -ENOMEM; >> >> >> -- >> Sathyanarayanan Kuppuswamy >> Android kernel developer >>
Powered by blists - more mailing lists