linux-kernel - Re: [GIT PULL] Driver core update for 4.7-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 22:39:37 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	William Breathitt Gray <vilhelm.gray@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Driver core update for 4.7-rc1

On Fri, May 20, 2016 at 10:20:19PM -0700, Linus Torvalds wrote:
> On Fri, May 20, 2016 at 10:04 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > What warnings?  I haven't seen any reports of warnings, what .config
> > causes them?
> 
> There's tons of them if you just do an allmodconfig build.
> 
> This suddenly enables a lot of random 16-bit ISA driver crap on
> x86-64, and not surprisingly it doesn't build cleanly, nor can most of
> those drivers work.
> 
> I'll just put a smattering of the warnings at the bottom, it scrolls
> off the screen.
> 
> These really are drivers that should not have been enabled. They are
> legacy crap, it's not worth anybodys time to try to "fix" them, they
> just shouldn't be on.
> 
>                  Linus
> 
> ---
> 
> drivers/ide/ht6560b.c: In function ‘ht6560b_init_dev’:
> drivers/ide/ht6560b.c:317:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>   ide_set_drivedata(drive, (void *)t);
>                            ^
> drivers/ide/qd65xx.c: In function ‘qd6500_init_dev’:
> drivers/ide/qd65xx.c:295:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>   ide_set_drivedata(drive, (void *)QD6500_DEF_DATA);
>                            ^
> drivers/ide/qd65xx.c: In function ‘qd6580_init_dev’:
> drivers/ide/qd65xx.c:311:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>   ide_set_drivedata(drive, (void *)((drive->dn & 1) ? t2 : t1));
>                            ^
> drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
> drivers/net/ethernet/3com/3c515.c:1066:8: warning: cast from pointer
> to integer of different size [-Wpointer-to-int-cast]
>    outl((int) (skb->data), ioaddr + Wn7_MasterAddr);
>         ^
> drivers/net/ethernet/amd/ni65.c: In function ‘ni65_stop_start’:
> drivers/net/ethernet/amd/ni65.c:756:16: warning: cast from pointer to
> integer of different size [-Wpointer-to-int-cast]
>     buffer[i] = (u32) isa_bus_to_virt(tmdp->u.buffer);
>                 ^
> drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff()
> falls through to next function ds1685_rtc_work_queue()
> drivers/net/wan/sdla.c: In function ‘sdla_transmit’:
> drivers/net/wan/sdla.c:714:13: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cast]
>       pbuf = (void *)(((int) dev->mem_start) + (addr & SDLA_ADDR_MASK));
>              ^

This is odd, I just tried this, and I don't get any error for
drivers/rtc/rtc-ds1685.c, nor any drivers/rtc/ file.

But I get the warning for drivers/ide/qd65xx.c, so that's not good.

Yeah, just revert it for now, let's not polute the build, sorry about
this.

thanks,

greg k-h