linux-kernel - Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGAzgsqxuOeP-UQkQyHS4zbUzVP26eHy=+ju+w1skKGe3Q=7=A@mail.gmail.com>
Date:	Fri, 20 May 2016 17:34:42 -0700
From:	"dbasehore ." <dbasehore@...omium.org>
To:	Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
Cc:	platform-driver-x86@...r.kernel.org, dvhart@...radead.org,
	linux-kernel <linux-kernel@...r.kernel.org>, olof@...om.net,
	vishwanath.somayaji@...el.com
Subject: Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

On Thu, May 12, 2016 at 6:50 AM, Rajneesh Bhardwaj
<rajneesh.bhardwaj@...el.com> wrote:
>
> + * pmc_dev contains info about power management controller device.
> + */
> +struct pmc_dev {
> +       u32 base_addr;
> +       void __iomem *regmap;
> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> +       struct dentry *dbgfs_dir;
> +#endif /* CONFIG_DEBUG_FS */
> +       bool has_slp_s0_res;
> +};
> +
> +int intel_pmc_slp_s0_counter_read(u64 *data);


Can this function be split out into another header file? The struct
pmc_dev is internal, but this function is needed as an external
interface.