lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 May 2016 13:19:02 +0200 From: Jiri Olsa <jolsa@...hat.com> To: Andi Kleen <andi@...stfloor.org> Cc: acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 2/2] perf stat: Add missing aggregation headers for --metric-only CSV On Fri, May 20, 2016 at 12:50:15PM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@...ux.intel.com> > > When in CSV mode --metric-only outputs an header, unlike the other > modes. Previously it did not properly print headers for the > aggregation columns, so the headers were actually shifted against > the real values. > > Fix this here by outputting the correct headers for CSV. > > Signed-off-by: Andi Kleen <ak@...ux.intel.com> > --- > tools/perf/builtin-stat.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 790eeea335cc..5d295da0e41c 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1311,6 +1311,14 @@ static int aggr_header_lens[] = { > [AGGR_GLOBAL] = 0, > }; > > +static const char *aggr_header_csv[] = { > + [AGGR_CORE] = "core,cpus,", > + [AGGR_SOCKET] = "socket,cpus", > + [AGGR_NONE] = "cpu,", > + [AGGR_THREAD] = "comm-pid,", > + [AGGR_GLOBAL] = "" > +}; please indent properly, otherwise Acked-by: Jiri Olsa <jolsa@...nel.org> thanks, jirka
Powered by blists - more mailing lists