lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 May 2016 10:55:43 -0500 From: Rob Landley <rob@...dley.net> To: Rich Felker <dalias@...c.org>, Daniel Lezcano <daniel.lezcano@...aro.org> Cc: linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver On 05/20/2016 10:15 PM, Rich Felker wrote: > On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote: >>> + return ((u64)sechi << 32 | seclo) * 1000000000 + nsec; >> >> s/1000000000/NSEC_PER_SEC/ ... >>> + hwirq = irq_get_irq_data(pit_irq)->hwirq; >>> + enable_val = (1<<26) | ((hwirq&0x3c)<<18) | (hwirq<<12); >> >> Can you explain? (and replace litterals by macros). "Hiding numbers that are used just once into defines to put them out of sight does not really help readability." - Pavel Machek http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00299.html Rob
Powered by blists - more mailing lists