linux-kernel - Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201605221719.28263@pali>
Date:	Sun, 22 May 2016 17:19:28 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Jean Delvare <jdelvare@...e.com>, Tolga Cakir <cevelnet@...il.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dell-smm-hwmon: Detect fan with index=2

On Sunday 22 May 2016 17:11:18 Guenter Roeck wrote:
> On 05/21/2016 05:31 PM, Pali Rohár wrote:
> > On Sunday 22 May 2016 02:21:46 Guenter Roeck wrote:
> >> On 05/21/2016 07:52 AM, Pali Rohár wrote:
> >>> Some Dell machines (e.g. Dell Precision M3800) have two fans,
> >>> first with index=0 and second with index=2. So export also
> >>> attributes for third fan device with index=2.
> >>> 
> >>> Reported-by: Tolga Cakir <cevelnet@...il.com>
> >>> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> >>> ---
> >>> 
> >>>    drivers/hwmon/dell-smm-hwmon.c |   20 +++++++++++++++++++-
> >>>    1 file changed, 19 insertions(+), 1 deletion(-)
> >>> 
> >>> ---
> >>> 
> >>> Hi Tolga! Can you test this patch if sensors see fan device
> >>> correctly?
> >> 
> >> I assume this means I should wait for test results before applying
> >> the patch ?
> > 
> > Yes, testing should be done.
> > 
> > Do you have some pending/testing/next tree/branch for such patches?
> 
> I have a hwmon-staging branch. I added your patches to it.
> 
> Please use "hwmon: (dell-smm)" in the subject line of your patches.
> The subsystem name should come first, the driver name in () is a
> hwmon idiosyncrasy, and we don't need to repeat the "hwmon".

Ok, I use generic "driver_name: description" pattern as each subsystem 
use different format. But I can send in above format future hwmon 
patches...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)