linux-kernel - Re: [PATCH] lightnvm: expose mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5742C01A.300@lightnvm.io>
Date:	Mon, 23 May 2016 10:32:26 +0200
From:	Matias Bjørling <mb@...htnvm.io>
To:	Javier González <jg@...htnvm.io>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	Javier González <javier@...xlabs.com>
Subject: Re: [PATCH] lightnvm: expose mark_blk through core

On 05/10/2016 09:25 AM, Javier González wrote:
> Expose mark_blk through the core LightNVM operations to hid the media
> manager, as we do for the rest of the block operations. This is
> necessary for targets to mark a growing bad block as bad before
> returning it to the media manager.
>
> Signed-off-by: Javier González <javier@...xlabs.com>
> ---
>   drivers/lightnvm/core.c  | 6 ++++++
>   include/linux/lightnvm.h | 2 ++
>   2 files changed, 8 insertions(+)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 160c1a6..13993c9 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -210,6 +210,12 @@ void nvm_put_blk(struct nvm_dev *dev, struct nvm_block *blk)
>   }
>   EXPORT_SYMBOL(nvm_put_blk);
>
> +void nvm_mark_blk(struct nvm_dev *dev, struct ppa_addr ppa, int type)
> +{
> +	return dev->mt->mark_blk(dev, ppa, type);
> +}
> +EXPORT_SYMBOL(nvm_mark_blk);
> +
>   int nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd)
>   {
>   	return dev->mt->submit_io(dev, rqd);
> diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
> index ef2c7d2..9c56148 100644
> --- a/include/linux/lightnvm.h
> +++ b/include/linux/lightnvm.h
> @@ -532,6 +532,8 @@ extern int nvm_register(struct request_queue *, char *,
>   						struct nvm_dev_ops *);
>   extern void nvm_unregister(char *);
>
> +void nvm_mark_blk(struct nvm_dev *dev, struct ppa_addr ppa, int type);
> +
>   extern int nvm_submit_io(struct nvm_dev *, struct nvm_rq *);
>   extern void nvm_generic_to_addr_mode(struct nvm_dev *, struct nvm_rq *);
>   extern void nvm_addr_to_generic_mode(struct nvm_dev *, struct nvm_rq *);
>

Thanks Javier. Applied for 4.8. I updated the description a bit.