linux-kernel - Re: [PATCH] pinctrl: mediatek: fix dual-edge code defect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5742DDE5.7050701@gmail.com>
Date:	Mon, 23 May 2016 12:39:33 +0200
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	hongkun.cao@...iatek.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, linux@....linux.org.uk,
	linus.walleij@...aro.org, erin.lo@...iatek.com
Cc:	devicetree@...r.kernel.org, srv_heupstream@...iatek.com,
	hongzhou.yang@...iatek.com, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, inux-mediatek@...ts.infradead.org,
	yingjoe.chen@...iatek.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pinctrl: mediatek: fix dual-edge code defect



On 21/05/16 09:23, hongkun.cao@...iatek.com wrote:
> From: "hongkun.cao" <hongkun.cao@...iatek.com>
>
> When a dual-edge irq is triggered, an incorrect irq will be reported on
> condition that the external signal is not stable and this incorrect irq
> has been registered.
> Correct the register offset.
>

I'm not sure what you want to say. From what I can see the without this 
fix, the the wrong IRQ will be cleared and raised. Is this what you are 
addressing?

If so:
Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> Signed-off-by: hongkun.cao <hongkun.cao@...iatek.com>
> ---
>   drivers/pinctrl/mediatek/pinctrl-mtk-common.c |    5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 2bbe6f7..92ae49f 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1255,9 +1255,10 @@ static void mtk_eint_irq_handler(struct irq_desc *desc)
>   	const struct mtk_desc_pin *pin;
>
>   	chained_irq_enter(chip, desc);
> -	for (eint_num = 0; eint_num < pctl->devdata->ap_num; eint_num += 32) {
> +	for (eint_num = 0;
> +	     eint_num < pctl->devdata->ap_num;
> +	     eint_num += 32, reg += 4) {
>   		status = readl(reg);
> -		reg += 4;
>   		while (status) {
>   			offset = __ffs(status);
>   			index = eint_num + offset;
>