linux-kernel - Re: [PATCH] dma-buf: use vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160523110128.GC13596@imgtec.com>
Date:	Mon, 23 May 2016 12:01:28 +0100
From:	Eric Engestrom <eric.engestrom@...tec.com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>
CC:	Sumit Semwal <sumit.semwal@...aro.org>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK" 
	<linaro-mm-sig@...ts.linaro.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:DMA BUFFER SHARING FRAMEWORK" 
	<dri-devel@...ts.freedesktop.org>,
	"open list:DMA BUFFER SHARING FRAMEWORK" 
	<linux-media@...r.kernel.org>
Subject: Re: [PATCH] dma-buf: use vma_pages().

On Sat, May 21, 2016 at 06:53:32PM +0530, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---

Good change, but this function is defined in mm.h
Please add:

    #include <linux/mm.h>

With that fixed:
Reviewed-by: Eric Engestrom <eric.engestrom@...tec.com>