linux-kernel - Re: [PATCH] KVM: Unify traced vector format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80e89f04-73d2-db95-8359-40c8d539a67f@redhat.com>
Date:	Mon, 23 May 2016 14:26:51 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Jan Kiszka <jan.kiszka@...mens.com>,
	Radim Krčmář <rkrcmar@...hat.com>
Cc:	kvm <kvm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: Unify traced vector format



On 23/05/2016 08:43, Jan Kiszka wrote:
> Specifically the change from hex to decimal helps correlating events.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>  include/trace/events/kvm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 526fb3d..f28292d 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -108,7 +108,7 @@ TRACE_EVENT(kvm_ioapic_set_irq,
>  		__entry->coalesced	= coalesced;
>  	),
>  
> -	TP_printk("pin %u dst %x vec=%u (%s|%s|%s%s)%s",
> +	TP_printk("pin %u dst %x vec %u (%s|%s|%s%s)%s",
>  		  __entry->pin, (u8)(__entry->e >> 56), (u8)__entry->e,
>  		  __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -129,7 +129,7 @@ TRACE_EVENT(kvm_ioapic_delayed_eoi_inj,
>  		__entry->e		= e;
>  	),
>  
> -	TP_printk("dst %x vec=%u (%s|%s|%s%s)",
> +	TP_printk("dst %x vec %u (%s|%s|%s%s)",
>  		  (u8)(__entry->e >> 56), (u8)__entry->e,
>  		  __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -151,7 +151,7 @@ TRACE_EVENT(kvm_msi_set_irq,
>  		__entry->data		= data;
>  	),
>  
> -	TP_printk("dst %u vec %x (%s|%s|%s%s)",
> +	TP_printk("dst %u vec %u (%s|%s|%s%s)",
>  		  (u8)(__entry->address >> 12), (u8)__entry->data,
>  		  __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
>  		  (__entry->address & (1<<2)) ? "logical" : "physical",
> 

Looks good, thanks.

Paolo