linux-kernel - Re: [PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160523123904.GB16764@phlsvsds.ph.intel.com>
Date:	Mon, 23 May 2016 08:39:05 -0400
From:	Dennis Dalessandro <dennis.dalessandro@...el.com>
To:	Shyam Saini <mayhs11saini@...il.com>
Cc:	gregkh@...uxfoundation.org, infinipath@...el.com,
	dledford@...hat.com, sean.hefty@...el.com,
	linux-rdma@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

On Mon, May 23, 2016 at 12:06:01PM +0530, Shyam Saini wrote:
>Fixed following checkpatch.pl warnings:
>  Prefer 'unsigned int' to bare use of 'unsigned'
>  Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)

In general please don't fix two types of issues in the same patch. Also, as 
to the unsinged -> unsigned int, the linux-rdma maintainer has already said 
we don't really want all of the code churn for this [1].

I suggest to respin this patch with just the ACCESS_ONCE->READ_ONCE change 
so that can be reviewed on it's own.

[1] http://marc.info/?l=linux-rdma&m=146308474205407&w=2

-Denny