[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160523153355.GA8449@redhat.com>
Date: Mon, 23 May 2016 17:33:55 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Michal Hocko <mhocko@...nel.org>
Cc: Aleksa Sarai <asarai@...e.de>, LKML <linux-kernel@...r.kernel.org>,
Martin Schwidefsky <schwidefsky@...ibm.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
linux-s390@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH] x86: fix potential memleak in do_error_trap
On 05/23, Michal Hocko wrote:
>
> @@ -271,6 +271,7 @@ static void do_error_trap(struct pt_regs *regs, long error_code, char *str,
>
> if (notify_die(DIE_TRAP, str, regs, error_code, trapnr, signr) !=
> NOTIFY_STOP) {
> + memset(&info, 0, sizeof(info));
> cond_local_irq_enable(regs);
> do_trap(trapnr, signr, str, regs, error_code,
> fill_trap_info(regs, signr, trapnr, &info));
at first glance fill_trap_info() initializes everything we will copy
to user-space in copy_siginfo_to_user(__SI_FAULT).
But even if not, shuldn't we change fill_trap_info() instead ?
Oleg.
Powered by blists - more mailing lists