linux-kernel - Re: [PATCH] drm/mm: avoid possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160523155048.GA23540@nuc-i3427.alporthouse.com>
Date:	Mon, 23 May 2016 16:50:48 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Eric Engestrom <eric.engestrom@...tec.com>
Cc:	Heinrich Schuchardt <xypron.glpk@....de>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/mm: avoid possible null pointer dereference

On Mon, May 23, 2016 at 04:35:53PM +0100, Eric Engestrom wrote:
> On Mon, May 23, 2016 at 02:46:59PM +0100, Chris Wilson wrote:
> > It's a programming error, just as would be passing in mm == NULL. Mark up
> > the function as requiring non-NULL parameters.
> 
> Using `__attribute__((nonnull))`? I approve of that idea, as I find
> those attributes extremely useful and try to get them used as much as
> possible at $DAYJOB.
> 
> I have noticed however that this particular attribute isn't used much in
> the kernel (4 times that I could find with a simple grep), to the point
> of not even having a `__nonnull`. Any reason you know of?

Not that I know of. Even more confusing is its use under tools but not
being added to the main kernel.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre