linux-kernel - Re: [PATCH] Fix RC5 decoding with Fintek CIR chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160523190106.GC6526@hardeman.nu>
Date:	Mon, 23 May 2016 21:01:06 +0200
From:	David Härdeman <david@...deman.nu>
To:	Jonathan McDowell <noodles@...th.li>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>
Subject: Re: [PATCH] Fix RC5 decoding with Fintek CIR chipset

On Sat, May 14, 2016 at 06:01:26PM +0100, Jonathan McDowell wrote:
>Fix RC5 decoding with Fintek CIR chipset
>
>Commit e87b540be2dd02552fb9244d50ae8b4e4619a34b tightened up the RC5
>decoding by adding a check for trailing silence to ensure a valid RC5
>command had been received. Unfortunately the trailer length checked was
>10 units and the Fintek CIR device does not want to provide details of a
>space longer than 6350us. This meant that RC5 remotes working on a
>Fintek setup on 3.16 failed on 3.17 and later. Fix this by shortening
>the trailer check to 6 units (allowing for a previous space in the
>received remote command).
>
>Signed-off-by: Jonathan McDowell <noodles@...th.li>
Signed-off-by: David Härdeman <david@...deman.nu>

>Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117221
>Cc: stable@...r.kernel.org
>
>-----
>diff --git a/drivers/media/rc/ir-rc5-decoder.c b/drivers/media/rc/ir-rc5-decoder.c
>index 6ffe776..a0fd4e6 100644
>--- a/drivers/media/rc/ir-rc5-decoder.c
>+++ b/drivers/media/rc/ir-rc5-decoder.c
>@@ -29,7 +29,7 @@
> #define RC5_BIT_START		(1 * RC5_UNIT)
> #define RC5_BIT_END		(1 * RC5_UNIT)
> #define RC5X_SPACE		(4 * RC5_UNIT)
>-#define RC5_TRAILER		(10 * RC5_UNIT) /* In reality, approx 100 */
>+#define RC5_TRAILER		(6 * RC5_UNIT) /* In reality, approx 100 */
> 
> enum rc5_state {
> 	STATE_INACTIVE,
>-----
>
>J.
>
>-- 
>What did the first punk rock girl wear to your school?
>

-- 
David Härdeman