linux-kernel - Re: [PATCH] xen/privcmd: use vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5743677D.7030603@oracle.com>
Date:	Mon, 23 May 2016 16:26:37 -0400
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>
Cc:	David Vrabel <david.vrabel@...rix.com>,
	Juergen Gross <jgross@...e.com>,
	"moderated list:XEN HYPERVISOR INTERFACE" 
	<xen-devel@...ts.xenproject.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen/privcmd: use vma_pages().

On 05/21/2016 09:09 AM, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---
>  drivers/xen/privcmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index df2e6f7..702040f 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -582,7 +582,7 @@ static long privcmd_ioctl(struct file *file,
>  static void privcmd_close(struct vm_area_struct *vma)
>  {
>  	struct page **pages = vma->vm_private_data;
> -	int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +	int numpgs = vma_pages(vma);
>  	int numgfns = (vma->vm_end - vma->vm_start) >> XEN_PAGE_SHIFT;
>  	int rc;
>  

Can you combine all three patches into a single one?

Thanks.
-boris