linux-kernel - Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WFQ4aG-LhB=s6KhdoHtAjuQnaW6duyzh1LUKAHdDXvTA@mail.gmail.com>
Date:	Mon, 23 May 2016 13:56:34 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Ulf Hansson <ulf.hansson@...aro.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Michal Simek <michal.simek@...inx.com>,
	soren.brinkmann@...inx.com, Rob Herring <robh+dt@...nel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Brian Norris <briannorris@...omium.org>,
	Heiko Stuebner <heiko@...ech.de>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description

Shawn,

On Sun, May 22, 2016 at 9:14 PM, Shawn Lin <shawn.lin@...k-chips.com> wrote:
> We introduce HS400 with enhanced strobe function, so we need
> to add it for debug show.
>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  drivers/mmc/core/debugfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index 9382a57..51d7c38 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -148,7 +148,9 @@ static int mmc_ios_show(struct seq_file *s, void *data)
>                 str = "mmc HS200";
>                 break;
>         case MMC_TIMING_MMC_HS400:
> -               str = "mmc HS400";
> +               mmc_card_hs400es(host->card) ?
> +                       (str = "mmc HS400 enhanced strobe") :
> +                       (str = "mmc HS400");

Not sure it's terribly important, but I've typically seen this as:

str = mmc_card_hs400es(host->card) ?
          "mmc HS400 enhanced strobe" : "mmc HS400";

AKA: don't repeat the "str ="

I doubt it really matters that much, though, so:

Reviewed-by: Douglas Anderson <dianders@...omium.org>
Tested-by: Douglas Anderson <dianders@...omium.org>