linux-kernel - Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201605240022.28140@pali>
Date:	Tue, 24 May 2016 00:22:28 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"D. Jared Dominguez" <Jared_Dominguez@...l.com>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	Alex Hung <alex.hung@...onical.com>,
	Andrei Borzenkov <arvidjaar@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

On Tuesday 24 May 2016 00:17:15 Darren Hart wrote:
> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote:
> > On Monday 23 May 2016 23:26:55 Darren Hart wrote:
> > > I've queued this. Thanks for your patience.
> > 
> > Ok, In that case I would update comments in patch to try it more
> > clear what code is doing.
> 
> I thought I had your approval on this one Pali. Apologies if that was
> not the case. Did I miss a change request from you?
> 
> If so, please point me at it, and I'll dequeue this one and wait for
> an updated one.

I just wanted to review that code from somebody else and decide if 
accept it or not. Because I was not sure if it is OK...

But there was no objection, so patch is OK.

And I pointed that patch could have better comments to describe what it 
is doing as at first time I was confused.

So I believe that you can update patch in your queue with new version 
which just change comments in source code (without functional changes).

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)