lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1464072626-21161-6-git-send-email-treeze.taeung@gmail.com> Date: Tue, 24 May 2016 15:50:24 +0900 From: Taeung Song <treeze.taeung@...il.com> To: Arnaldo Carvalho de Melo <acme@...nel.org> Cc: linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Taeung Song <treeze.taeung@...il.com>, Jiri Olsa <jolsa@...hat.com>, Wang Nan <wangnan0@...wei.com>, Ingo Molnar <mingo@...hat.com>, Masami Hiramatsu <mhiramat@...nel.org> Subject: [PATCH v3 5/7] perf config: Introduce perf_default_config_init() default_*_config_init() initialize actual variables with each default config value. (e.g. default_colors_config_init() for 'colors' section) But I suggest using perf_default_config_init() that call all default_*_config_init() and this function would be called at the very beginning of main() on perf.c. In order to set all default config values before running a particular sub-command. And if we do, we can manage all default_*_config_init() functions in perf_default_config_init(). Cc: Namhyung Kim <namhyung@...nel.org> Cc: Jiri Olsa <jolsa@...hat.com> Cc: Wang Nan <wangnan0@...wei.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Ingo Molnar <mingo@...hat.com> Cc: Masami Hiramatsu <mhiramat@...nel.org> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com> Signed-off-by: Taeung Song <treeze.taeung@...il.com> --- tools/perf/perf.c | 6 ++++++ tools/perf/ui/browser.c | 1 - tools/perf/util/cache.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/perf.c b/tools/perf/perf.c index 15982ce..e140b551 100644 --- a/tools/perf/perf.c +++ b/tools/perf/perf.c @@ -77,6 +77,11 @@ struct pager_config { int val; }; +static void perf_default_config_init(void) +{ + default_colors_config_init(); +} + static int pager_command_config(const char *var, const char *value, void *data) { struct pager_config *c = data; @@ -558,6 +563,7 @@ int main(int argc, const char **argv) srandom(time(NULL)); + perf_default_config_init(); perf_config(perf_default_config, NULL); set_buildid_dir(NULL); diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 00a91e0..c07ca70 100644 --- a/tools/perf/ui/browser.c +++ b/tools/perf/ui/browser.c @@ -738,7 +738,6 @@ void ui_browser__init(void) { int i = 0; - default_colors_config_init(); perf_config(ui_browser__color_config, NULL); while (ui_browser__colorsets[i].name) { diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h index 54bbd55..19e1e00 100644 --- a/tools/perf/util/cache.h +++ b/tools/perf/util/cache.h @@ -7,6 +7,7 @@ #include <subcmd/pager.h> #include "../perf.h" #include "../ui/ui.h" +#include "../ui/browser.h" #include "config.h" #include <linux/string.h> -- 2.5.0
Powered by blists - more mailing lists